cloudstack.git
4 hours agoReturn vm userdata (#6683) main
João Jandre [Mon, 26 Sep 2022 22:12:28 +0000 (19:12 -0300)] 
Return vm userdata (#6683)

* [UI] Update vm userdata

* fix vm id

* Address review

* Address review

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
4 hours agoAdded new logs to volume creation (#6689)
João Jandre [Mon, 26 Sep 2022 22:11:14 +0000 (19:11 -0300)] 
Added new logs to volume creation (#6689)

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
2 days agofix description of configuration `max.data.migration.wait.time` (#6749)
GaOrtiga [Sat, 24 Sep 2022 18:27:34 +0000 (15:27 -0300)] 
fix description of configuration `max.data.migration.wait.time` (#6749)

Co-authored-by: Gabriel Ortiga Fernandes <gabriel.fernandes@scclouds.com.br>
3 days agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Fri, 23 Sep 2022 11:44:59 +0000 (17:14 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
3 days agoDatabaseUpgradeChecker: add upgrade path from 4.17.0.1 to 4.17.1.0 (#6759)
Rohit Yadav [Fri, 23 Sep 2022 11:42:18 +0000 (17:12 +0530)] 
DatabaseUpgradeChecker: add upgrade path from 4.17.0.1 to 4.17.1.0 (#6759)

Fixes DB upgrade for 4.17.0.1 to 4.17.1.0

4 days agoAllow option of exposing VM domain info via instance metadata (#6710)
Marcus Sorensen [Thu, 22 Sep 2022 09:44:21 +0000 (03:44 -0600)] 
Allow option of exposing VM domain info via instance metadata (#6710)

This PR allows the cloud admin to set either a global or domain-specific value "metadata.allow.expose.domain", and when set this allows the VM to see the name and ID of the immediate domain that contains the VM in instance metadata. This can be useful or a variety of things such as bootstrapping VM configuration and access according to domain.

This PR also deletes the CloudZonesNetworkElement because it isn't referred to anywhere, and there was initially some confusion as to whether this code needed to be updated when extending metadata. If it needs to be kept we can remove that delete from the PR.

Signed-off-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
5 days agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Wed, 21 Sep 2022 08:16:34 +0000 (13:46 +0530)] 
Merge remote-tracking branch 'origin/4.17'

5 days agomvn: fix build and use the 4.17.2.0-SNAPSHOT in version
Rohit Yadav [Wed, 21 Sep 2022 08:11:21 +0000 (13:41 +0530)] 
mvn: fix build and use the 4.17.2.0-SNAPSHOT in version

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
7 days agoUpdating pom.xml version numbers for release 4.17.2.0-SNAPSHOT
Abhishek Kumar [Mon, 19 Sep 2022 10:51:35 +0000 (16:21 +0530)] 
Updating pom.xml version numbers for release 4.17.2.0-SNAPSHOT

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
10 days agoResource reservation framework (#6694)
dahn [Fri, 16 Sep 2022 10:14:35 +0000 (12:14 +0200)] 
Resource reservation framework (#6694)

This PR addresses parallel resource allocation as a generalization of the problem and solution described in #6644. Instead of the Global lock on the resources a reservation record is created which is added in the resource check count in the ResourceLimitService/ResourceLimitManagerImpl. As a convenience a CheckedReservation is created. This is an implementation of AutoClosable and can be used as a guard in a try-with-resource fashion. The close method of the CheckedReservation wil delete the reservation record.

Co-authored-by: Boris Stoyanov - a.k.a Bobby <bss.stoyanov@gmail.com>
11 days agoui: fixes errors in the Console.vue (#6741)
Hoang Nguyen [Thu, 15 Sep 2022 11:14:31 +0000 (18:14 +0700)] 
ui: fixes errors in the Console.vue (#6741)

This PR for fixes errors in the Console.vue

12 days agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Wed, 14 Sep 2022 07:47:57 +0000 (13:17 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

12 days agoUpdating pom.xml version numbers for release 4.17.1.0
Abhishek Kumar [Wed, 14 Sep 2022 07:28:03 +0000 (12:58 +0530)] 
Updating pom.xml version numbers for release 4.17.1.0

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
12 days ago UI fix Theme text color not bind navTextColorPick and reset button (#6721)
hooklee2000 [Wed, 14 Sep 2022 07:26:58 +0000 (15:26 +0800)] 
 UI fix Theme text color not bind navTextColorPick and reset button (#6721)

UI fix Theme text color not bind navTextColorPick fix #6720

12 days agoFix min balance for API quotaCredits to be optional (#6691)
Bryan Lima [Wed, 14 Sep 2022 07:21:03 +0000 (04:21 -0300)] 
Fix min balance for API quotaCredits to be optional (#6691)

12 days agoUI: Build Dockerfile with Node v14 (#6712)
Wido den Hollander [Wed, 14 Sep 2022 07:18:14 +0000 (09:18 +0200)] 
UI: Build Dockerfile with Node v14 (#6712)

Node versions >14 throw errors when building and thus do not allow to
build the UI.

Pinning to v14 allows us to build and run the UI Docker container.

12 days agoconsole: Console access enhancements (#6577)
Nicolas Vazquez [Wed, 14 Sep 2022 07:09:59 +0000 (04:09 -0300)] 
console: Console access enhancements (#6577)

This PR creates a new API createConsoleAccess to create VM console URL allowing it to connect using other UI implementations. To avoid reply attacks, the console access is enhanced to use a one time token per session

New configuration added:
consoleproxy.extra.security.validation.enabled: Enable/disable extra security validation for console proxy using a token

Documentation PR: apache/cloudstack-documentation#284

12 days agoImprove error message on storage tags update (#6269)
Bryan Lima [Wed, 14 Sep 2022 07:06:20 +0000 (04:06 -0300)] 
Improve error message on storage tags update (#6269)

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
13 days agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Tue, 13 Sep 2022 08:47:34 +0000 (14:17 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

13 days agoMerge remote-tracking branch 'apache/4.16' into 4.17
Abhishek Kumar [Tue, 13 Sep 2022 08:45:38 +0000 (14:15 +0530)] 
Merge remote-tracking branch 'apache/4.16' into 4.17

13 days agoReset unusable db connections (#6725) 4.16
mrog [Tue, 13 Sep 2022 08:42:53 +0000 (02:42 -0600)] 
Reset unusable db connections (#6725)

When the management service detects a broken database connection, it didn't do anything about it. It already has code to reset the connection, but that doesn't get used. This change causes the connection to be reset after it's found to be unusable.

Fixes #6724 (see issue for repro steps)

13 days agoserver: fix netowork upgrade for IPv6 (#6729)
Abhishek Kumar [Tue, 13 Sep 2022 08:41:15 +0000 (14:11 +0530)] 
server: fix netowork upgrade for IPv6 (#6729)

Fixes network update for IPv6 offering upgrade

13 days agoupgrade a backported patch (#6728)
dahn [Tue, 13 Sep 2022 05:03:36 +0000 (07:03 +0200)] 
upgrade a backported patch (#6728)

This PR tries to fix a problem with a privately backported feature. The columns added for the feature are not added idem potent so people can not backport them. I propose that all DB alteration from here on in will be done with the IDEM_POTENT_...() set of stored procedures that we have to prevent these kind of issues for users.

2 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Mon, 12 Sep 2022 16:00:03 +0000 (21:30 +0530)] 
Merge remote-tracking branch 'origin/4.17'

2 weeks agojacoco: fix no coverage result in server and some other modules (#6730)
Wei Zhou [Mon, 12 Sep 2022 15:57:55 +0000 (17:57 +0200)] 
jacoco: fix no coverage result in server and some other modules (#6730)

According to https://www.eclemma.org/jacoco/trunk/doc/prepare-agent-mojo.html
we need to add "@{argLine}" to argLine if it exists in pom.xml

2 weeks agoapi,server: custom dns for guest network (#6425)
Abhishek Kumar [Sat, 10 Sep 2022 07:35:40 +0000 (13:05 +0530)] 
api,server: custom dns for guest network (#6425)

Adds option to provide custom DNS servers for isolated network, shared network and VPC tier.
New API parameters added in createNetwork API along with the corresponding response parameters.

Doc PR: apache/cloudstack-documentation#276

2 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Wed, 7 Sep 2022 08:41:09 +0000 (14:11 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

2 weeks agosystemvm,vr: disable radvd for non-applicable VRs (#6706)
Abhishek Kumar [Wed, 7 Sep 2022 08:12:57 +0000 (13:42 +0530)] 
systemvm,vr: disable radvd for non-applicable VRs (#6706)

Fixes #6700

When VR is a DHCP server system VM type then stop radvd.

2 weeks agoui: Fix netowrkid not passed in deployvm (#6711)
David Jumani [Wed, 7 Sep 2022 06:55:23 +0000 (12:25 +0530)] 
ui: Fix netowrkid not passed in deployvm (#6711)

Fixes the issue of the networkid not being passed when deploying a VM
This is caused when the first template selected is a deploy-as-is one and the nicToNetworkSelection not being reset when selecting a new template

2 weeks agoUI: fix bulk delete project with cleanup (#6708)
Wei Zhou [Wed, 7 Sep 2022 05:43:45 +0000 (07:43 +0200)] 
UI: fix bulk delete project with cleanup (#6708)

2 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Tue, 6 Sep 2022 13:17:47 +0000 (18:47 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

2 weeks agokvm: add libvirt host capabilities method for cpu speed retrieval (#6696)
Abhishek Kumar [Tue, 6 Sep 2022 11:15:05 +0000 (16:45 +0530)] 
kvm: add libvirt host capabilities method for cpu speed retrieval (#6696)

Fixes #6680

While finding CPU speed for KVM host following methods will be used in the same order:
1. lscpu
2. value in /sys/devices/system/cpu/cpu0/cpufreq/base_frequency
3. virsh capabilities
4. libvirt nodeinfo

This will allow correct value for AMD based hosts when first two methods doesn't give a value
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2 weeks agoserver: fix check for ipv6 range overlap (#6705)
Abhishek Kumar [Tue, 6 Sep 2022 11:13:20 +0000 (16:43 +0530)] 
server: fix check for ipv6 range overlap (#6705)

Fixes incorrect check for verifying IPv6 ranges overlap. This causes the inability to add multiple IPv6 ranges.

2 weeks agoui: fix set reservation toggle in add public ip range (#6707)
Abhishek Kumar [Tue, 6 Sep 2022 08:35:01 +0000 (14:05 +0530)] 
ui: fix set reservation toggle in add public ip range (#6707)

Fixes 'Set reservation' toggle not getting updated on value change.

3 weeks agoIgnore opensaml dependencies (#6693)
Daniel Augusto Veronezi Salvador [Mon, 5 Sep 2022 12:08:45 +0000 (09:08 -0300)] 
Ignore opensaml dependencies (#6693)

Commit f27de63 introduced a new version of opensaml. That version brought jcl-over-slf4j-1.7.5.jar, jul-to-slf4j-1.7.5.jar, and log4j-over-slf4j-1.7.5.jar as dependencies, which causes Agents and Usages to not generate logs.
In order to make the logs to work again, this PR intends to exclude these dependencies while building the packages.

3 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Thu, 1 Sep 2022 07:26:31 +0000 (12:56 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

3 weeks agoserver: fix scale vm with compute offering having same disk offering (#6688)
Abhishek Kumar [Thu, 1 Sep 2022 06:58:39 +0000 (12:28 +0530)] 
server: fix scale vm with compute offering having same disk offering (#6688)

Fixes #6679

Fixes behaviour when the VM is scaled to a new compute offering which has the same disk offering associated as the earlier compute offering.

3 weeks agoRemove unsupported params from API calls on the UI (#6686)
Bryan Lima [Wed, 31 Aug 2022 13:34:25 +0000 (10:34 -0300)] 
Remove unsupported params from API calls on the UI (#6686)

3 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Wed, 31 Aug 2022 12:08:30 +0000 (17:38 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

3 weeks agovmware: fix vm snapshot with datastore cluster, drs (#6643)
Abhishek Kumar [Wed, 31 Aug 2022 10:30:14 +0000 (16:00 +0530)] 
vmware: fix vm snapshot with datastore cluster, drs (#6643)

Fixes #6595
Sync volume datastore, path and chaininfo info while calculating snapshot chain size after snapshot operation is complete from vCenter.

3 weeks agoValidate host tags on VM live scale (#6409)
Bryan Lima [Wed, 31 Aug 2022 07:24:00 +0000 (04:24 -0300)] 
Validate host tags on VM live scale (#6409)

* Validate host tags on VM live scale

* Remove extra spaces

3 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Tue, 30 Aug 2022 10:52:59 +0000 (12:52 +0200)] 
Merge remote-tracking branch 'origin/4.17'

3 weeks agoui: remove incorrect API calls when initializing the deploy VM page (#6687)
Hoang Nguyen [Tue, 30 Aug 2022 10:36:34 +0000 (17:36 +0700)] 
ui: remove incorrect API calls when initializing the deploy VM page (#6687)

4 weeks agoVM stats history visualization (#6401)
José Flauzino [Mon, 29 Aug 2022 11:42:03 +0000 (08:42 -0300)] 
VM stats history visualization (#6401)

* Add VM stats view feature

* Add dynamic label to the submit button of the VM stats filtering modal

* Improve CPU info message

* Reduce identation

* Remove missed line

* Fix timestamp when 'Use local timezone' is selected

* Fix bug when filtering for all data

* Support for toggle 'Use local timezone' button

Co-authored-by: joseflauzino <jose@scclouds.com.br>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
4 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Fri, 26 Aug 2022 08:52:14 +0000 (14:22 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

4 weeks agoui: fix update network update in sequence param (#6675)
Abhishek Kumar [Fri, 26 Aug 2022 08:51:13 +0000 (14:21 +0530)] 
ui: fix update network update in sequence param (#6675)

Fixes wrong param used in the update network form

4 weeks agoserver: fix error when dedicating guest vlan range for physical nw without vlan range...
Abhishek Kumar [Thu, 25 Aug 2022 16:57:44 +0000 (22:27 +0530)] 
server: fix error when dedicating guest vlan range for physical nw without vlan range (#6655)

Fixes #6648
If any of the VLAN from the given range is not found in the database (cloud.op_dc_vnet_alloc) then an InvalidParameterValueException will be thrown.
Also, refactors and fixes account check.

4 weeks agoUI: Fixes suffix icon on project selector not work (#6671)
Hoang Nguyen [Thu, 25 Aug 2022 16:44:31 +0000 (23:44 +0700)] 
UI: Fixes suffix icon on project selector not work (#6671)

* fix the animation suffix icon of select

* move style code

4 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Thu, 25 Aug 2022 04:39:11 +0000 (10:09 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

4 weeks agovpc: prevent sourcenat ip disassociation for an active vpc (#6664)
Abhishek Kumar [Wed, 24 Aug 2022 07:53:01 +0000 (13:23 +0530)] 
vpc: prevent sourcenat ip disassociation for an active vpc (#6664)

Fixes #6663

Source NAT IP should not be disassociated from an active vpc

5 weeks agoui: Revise Chinese language pack (#6653)
Rohit Yadav [Mon, 22 Aug 2022 11:38:34 +0000 (13:38 +0200)] 
ui: Revise Chinese language pack (#6653)

Co-authored-by: 卢苇 <lw_bk@163.com>
5 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Mon, 22 Aug 2022 09:12:35 +0000 (14:42 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

5 weeks agocks: fix k8s cluster deployment with host tagged offering (#6658)
Abhishek Kumar [Mon, 22 Aug 2022 09:09:36 +0000 (14:39 +0530)] 
cks: fix k8s cluster deployment with host tagged offering (#6658)

Fixes #6657

Fixes k8s cluster node VM deployment when the underlying hypervisor host has multiple host tags and the service offering used for the cluster deployment does not contain all of those host tags.

5 weeks agoapi, vmware: allow VM setting/detail for disk controller (root/data) to override...
Pearl Dsilva [Mon, 22 Aug 2022 07:57:07 +0000 (13:27 +0530)] 
api, vmware: allow VM setting/detail for disk controller (root/data) to override template details (#6276)

This PR allows VM details wrt root & data disk controller passed via details parameter of deployVMCmd to take precedence over template settings, i.e., the order of precedence for determining VM disk controller is : VM details passed during deployment > template settings > global setting vmware.root.disk.controller.

5 weeks agoserver: remove resource tags for disassociated public ip (#6642)
Abhishek Kumar [Fri, 19 Aug 2022 12:58:51 +0000 (18:28 +0530)] 
server: remove resource tags for disassociated public ip (#6642)

Fixes #6620
Remove resource tags when public IP is disassociated

5 weeks agoFix SQL query for uuid wrong format (#6654)
Nicolas Vazquez [Fri, 19 Aug 2022 12:57:11 +0000 (09:57 -0300)] 
Fix SQL query for uuid wrong format (#6654)

Fixes: #6652

5 weeks agokvm: Add usermode interface option to Libvirt Domain XML builder (#6640)
Marcus Sorensen [Thu, 18 Aug 2022 07:44:50 +0000 (01:44 -0600)] 
kvm: Add usermode interface option to Libvirt Domain XML builder (#6640)

This PR provides constructors and the associated changes to use LibvirtVMDef for creating user mode network interfaces.

While this isn't used directly in the CloudStack KVM agent today, it could be used in the future for e.g. pod networking/management networks without needing to assign a pod IP. The VIF driver used by the CloudStack Agent is also pluggable, so this allows plugin code to create user mode network interfaces as well.

Note that the user mode network already exists in the GuestNetType enum, but wasn't usable prior to this change.

Also included unit test to ensure we continue to create the expected XML.

Additionally, this uncovered a null pointer on _networkRateKBps and this PR fixes it. The decision to add bandwidth throttling assumes this field is not null and simply checks for > 0.

Signed-off-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
5 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Wed, 17 Aug 2022 14:25:25 +0000 (16:25 +0200)] 
Merge remote-tracking branch 'origin/4.17'

5 weeks agoserver: fix ipv6 network deployment with separate guest nw (#6588)
Abhishek Kumar [Wed, 17 Aug 2022 10:19:01 +0000 (15:49 +0530)] 
server: fix ipv6 network deployment with separate guest nw (#6588)

Fixes #6584

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
5 weeks agoui: fix resource tags visibility in infocard (#6650)
Abhishek Kumar [Wed, 17 Aug 2022 10:17:31 +0000 (15:47 +0530)] 
ui: fix resource tags visibility in infocard (#6650)

Fixes #6649

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
5 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Wed, 17 Aug 2022 08:29:40 +0000 (10:29 +0200)] 
Merge remote-tracking branch 'origin/4.17'

5 weeks agoserver: fix delete resource tag permission (#6634)
Abhishek Kumar [Wed, 17 Aug 2022 06:27:44 +0000 (11:57 +0530)] 
server: fix delete resource tag permission (#6634)

Fixes #6623
This PR fixes resource tag deletion behaviour. The permission check should be done only for the tags that are passed in the API call instead of checking for all the tags for the resource.

5 weeks agoui: fix gputype in add compute offering (#6646)
Abhishek Kumar [Wed, 17 Aug 2022 06:23:22 +0000 (11:53 +0530)] 
ui: fix gputype in add compute offering (#6646)

Fixes gpuType value in the add compute offering form during submit

5 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Tue, 16 Aug 2022 12:21:09 +0000 (17:51 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

5 weeks agoui: fix the warning in detail tab (#6645)
Hoang Nguyen [Tue, 16 Aug 2022 11:11:19 +0000 (18:11 +0700)] 
ui: fix the warning in detail tab (#6645)

This PR for fixes the warning in detail tab

5 weeks agovmware,cks: fix attachiso failure with vmware drs (#6625)
Abhishek Kumar [Tue, 16 Aug 2022 10:47:13 +0000 (16:17 +0530)] 
vmware,cks: fix attachiso failure with vmware drs (#6625)

Fixes #4314

Failure in attaching k8s ISO is seen when VMware DRS is enabled. Log reported VM is not found. This fix tries to find VM on peer hosts when the VM is not found on the given host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
5 weeks agoUpdated resource counter to include correct size after volume creation/resize and...
Suresh Kumar Anaparti [Tue, 16 Aug 2022 08:41:42 +0000 (14:11 +0530)] 
Updated resource counter to include correct size after volume creation/resize and other improvements (#6587)

* Updated resource counter to include correct size after volume creation/resize and other improvements
- Recalculate resource counters for root domain in the periodic task
- Update correct size in the primary_storage resource counter after volume creation/resize
- Some code improvements

* review and sonarcloud issues

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Co-authored-by: Daan Hoogland <daan@onecht.net>
5 weeks agoui: reset disksize param on offering change in scale vm (#6636)
Abhishek Kumar [Tue, 16 Aug 2022 06:14:32 +0000 (11:44 +0530)] 
ui: reset disksize param on offering change in scale vm (#6636)

Fixes #6627

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
6 weeks agoREADME: add codecov badge
Rohit Yadav [Sun, 14 Aug 2022 12:39:13 +0000 (18:09 +0530)] 
README: add codecov badge

6 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Fri, 12 Aug 2022 18:14:42 +0000 (23:44 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

6 weeks agoschema: increase size of column 'value' at table 'account_details' (#6080)
Gabriel Beims Bräscher [Fri, 12 Aug 2022 18:12:50 +0000 (15:12 -0300)] 
schema: increase size of column 'value' at table 'account_details' (#6080)

This PR increases the column value at table account_details from 255 chars to 4096, matching with the value allowed in the API command for updating the configuration of accounts.

When the value length is bigger than 255, the following log is presented right after the updateConfiguration API call:

2022-03-09 17:50:24,627 ERROR [c.c.a.ApiServer] (qtp30578394-234766:ctx-cad18b45 ctx-32e954dd) (logid:0948e203) unhandled exception executing api command: [Ljava.lang.String;@117c6ba7
com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: INSERT INTO account_details (account_details.account_id, account_details.name, account_details.value) VALUES (123, _binary'api.allowed.source.cidr.list', _binary'<huge binary>')
at com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1450)
at jdk.internal.reflect.GeneratedMethodAccessor168.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
....
....
....
Caused by: com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'value' at row 1
at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:104)
at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953)
at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1092)
... 83 more

Co-authored-by: Bart Meyers <bart.meyers@cldin.eu>
6 weeks agokvm: update host memory stats (#6622)
Ruben Bosch [Fri, 12 Aug 2022 11:44:04 +0000 (13:44 +0200)] 
kvm: update host memory stats (#6622)

Fixes #6621

Each time getMemStat() is called, a static value is returned. This value
should instead be refreshed to return the actual memory used.

Co-authored-by: Ruben Bosch <ruben.bosch@cldin.eu>
6 weeks agoImprove log messages on VolumeOrchestrator class (#6408)
Paula Oliveira [Fri, 12 Aug 2022 07:17:06 +0000 (04:17 -0300)] 
Improve log messages on VolumeOrchestrator class (#6408)

Co-authored-by: Paula Zomignani Oliveira <paula@scclouds.com.br>
6 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Wed, 10 Aug 2022 21:11:09 +0000 (23:11 +0200)] 
Merge remote-tracking branch 'origin/4.17'

6 weeks agoFixed Veeam listing restore points (#6555)
Harikrishna [Wed, 10 Aug 2022 11:29:10 +0000 (16:59 +0530)] 
Fixed Veeam listing restore points (#6555)

Fixes issue #6465 where listing backup restore points are failing with Veeam version v11.0.1.1261.

Though this version is not fully supported for backup and recovery, existing backups, restore points for the VMs can continue to work with the Veeam version v11.0.1.1261. I've created a separate ticket here to fully support the version #6554

6 weeks agoremoved the use of SharedMountPoint storage type for the StorPool plugin (#6552)
slavkap [Wed, 10 Aug 2022 09:11:32 +0000 (12:11 +0300)] 
removed the use of SharedMountPoint storage type for the StorPool plugin (#6552)

Fixes #6455

The default storage adaptor - LibvirtStorageAdaptor - is used by different storage types and doesn't use the annotation @StorageAdaptorInfo. In this case, a storage plugin that wants to adopt one of the predefined storage pool types will override the default behaviour. If fixing the issue in general (for new storage plugins or current ones that want to reuse the existing storage pool types) would affect all volume/snapshot/VM cases. This will lead to the need of extensive testing for each storage plugin for which we don't have the resources to do it. That's why this patch fixes the old behaviour for the SharedMountPoint by adding a new storage pool type for the StorPool plugin.

6 weeks agovpc,network: fix createLoadBalancer access on user network (#6591)
Abhishek Kumar [Tue, 9 Aug 2022 11:06:39 +0000 (16:36 +0530)] 
vpc,network: fix createLoadBalancer access on user network (#6591)

While checking network access for creating load-balancer use AccessType.OperateEntry
Refactor variable name in NetworkModelImpl::checkNetworkPermissions

Fixes: #6590

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
6 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Tue, 9 Aug 2022 10:33:39 +0000 (12:33 +0200)] 
Merge remote-tracking branch 'origin/4.17'

6 weeks ago.github: add codecov coverage check
Rohit Yadav [Tue, 9 Aug 2022 10:29:19 +0000 (12:29 +0200)] 
.github: add codecov coverage check

It seems codecov can overcome the pull_request_target limitation/issue
compared to sonarcloud coverage. We've some other Apache projects who
use `codecov` now and this ticket to add support with infra:
https://issues.apache.org/jira/browse/INFRA-23561

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
6 weeks agoui: use ssh keypair uuid for listing (#6616)
Abhishek Kumar [Tue, 9 Aug 2022 07:59:49 +0000 (13:29 +0530)] 
ui: use ssh keypair uuid for listing (#6616)

Addresses #6569

Use uuid to list SSH keypair wherever uuid is available.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
6 weeks agotest,xcp-ng: fix tests for VM PV driver issue (#6549)
Abhishek Kumar [Tue, 9 Aug 2022 07:14:27 +0000 (12:44 +0530)] 
test,xcp-ng: fix tests for VM PV driver issue (#6549)

Few of the smoke tests fail on XCP-ng8 with PV drivers not installed for the VM.
This PR makes changes to use get_suitable_test_template instead of get_template to use the appropriate template for the VM deployed during the test.
After volume migration VM becomes unusable for attach/detach volume action.
A new template could be used in future. For workaround right now, tests are ordered in a way that migrate volume test run at the end.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
6 weeks agoEnable system VM volume migration for KVM (#6341)
Daniel Augusto Veronezi Salvador [Tue, 9 Aug 2022 04:33:03 +0000 (01:33 -0300)] 
Enable system VM volume migration for KVM (#6341)

Release 4.16.0.0 introduced a feature for migrating system VM volumes (#4385). However, it was enabled only for VMWare.

This PR intends to enable the feature for KVM too.

Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
7 weeks agoMerge remote-tracking branch 'origin/4.17'
Rohit Yadav [Mon, 8 Aug 2022 09:57:37 +0000 (11:57 +0200)] 
Merge remote-tracking branch 'origin/4.17'

7 weeks agoAdd new parameter to createLoadBalancerRule API (#6460)
João Jandre [Mon, 8 Aug 2022 08:48:21 +0000 (05:48 -0300)] 
Add new parameter to createLoadBalancerRule API (#6460)

* Add new parameter to createLoadBalancerRule API

* address review

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
7 weeks agoui: fix hypervisortrafficlabel for phy nw traffic (#6612)
Abhishek Kumar [Fri, 5 Aug 2022 05:12:13 +0000 (10:42 +0530)] 
ui: fix hypervisortrafficlabel for phy nw traffic (#6612)

Fixes: #6593

Before fix UI was setting vlan to 'null' when no value was passed. Now it just leaves the vlan value empty in the trafficlabel.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
7 weeks agoCreate password policies configurations (#6567)
João Jandre [Wed, 3 Aug 2022 14:09:00 +0000 (11:09 -0300)] 
Create password policies configurations (#6567)

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
7 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Wed, 3 Aug 2022 11:15:36 +0000 (16:45 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

7 weeks agoUI: Fix delete ISO navigation after job is finished (#6598)
Nicolas Vazquez [Wed, 3 Aug 2022 11:14:31 +0000 (08:14 -0300)] 
UI: Fix delete ISO navigation after job is finished (#6598)

* UI: Fix delete ISO navigation after job is finished

* Apply suggestion

* Fix redirection

7 weeks agoui: Close form right after receiving the job id (#6603)
Daniel Augusto Veronezi Salvador [Wed, 3 Aug 2022 10:50:23 +0000 (07:50 -0300)] 
ui: Close form right after receiving the job id (#6603)

When restoring and attaching a backup volume, the UI waits for the successfful response of the API to close the formulary. However, letting the form open after sending the command can confuse users, that might try to send the command again.

Note: other formularies (like volume or snapshot creation) always are closed after sending the command to the backend.

With this PR, we intend to close the formulary right after sending the command, as done with others.

Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
7 weeks agoapidocs: Shows quotaSummary in API documentation (#6605)
Rodrigo D. Lopez [Wed, 3 Aug 2022 10:48:14 +0000 (07:48 -0300)] 
apidocs: Shows quotaSummary in API documentation (#6605)

Co-authored-by: Lopez <rodrigo@scclouds.com.br>
7 weeks agoFix spelling (#6597)
John Bampton [Wed, 3 Aug 2022 10:13:47 +0000 (20:13 +1000)] 
Fix spelling (#6597)

7 weeks agoUI: Fixes notification error can't close when exit config limit tab (#6607)
Hoang Nguyen [Wed, 3 Aug 2022 10:01:16 +0000 (17:01 +0700)] 
UI: Fixes notification error can't close when exit config limit tab (#6607)

* fixed an error that generated incorrect messages when accessing the config limit tab

* removed deep:true

7 weeks agoui: fix icon for vr migrate storage (#6600)
Abhishek Kumar [Tue, 2 Aug 2022 10:46:57 +0000 (16:16 +0530)] 
ui: fix icon for vr migrate storage (#6600)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
7 weeks agoFind VBRViDatastore/VBRServer by name (#6582)
SadiJr [Tue, 2 Aug 2022 07:07:03 +0000 (04:07 -0300)] 
Find VBRViDatastore/VBRServer by name (#6582)

Co-authored-by: Rafael Weingärtner <rafaelweingartner@gmail.com>
7 weeks agoList service offerings without host tags when filtering VM which the current service...
Daniel Augusto Veronezi Salvador [Tue, 2 Aug 2022 06:50:56 +0000 (03:50 -0300)] 
List service offerings without host tags when filtering VM which the current service offering has host tags (#6359)

Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
7 weeks agoexternalizes used protocol to upload isos, volumes and templates (#6506)
Rodrigo D. Lopez [Tue, 2 Aug 2022 06:46:55 +0000 (03:46 -0300)] 
externalizes used protocol to upload isos, volumes and templates (#6506)

Co-authored-by: Lopez <rodrigo@scclouds.com.br>
8 weeks agoMerge remote-tracking branch 'apache/4.17' into main
Abhishek Kumar [Mon, 1 Aug 2022 02:43:43 +0000 (08:13 +0530)] 
Merge remote-tracking branch 'apache/4.17' into main

8 weeks agoui: fix vpc loadbalancer listing for admins (#6592)
Abhishek Kumar [Mon, 1 Aug 2022 02:24:09 +0000 (07:54 +0530)] 
ui: fix vpc loadbalancer listing for admins (#6592)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
8 weeks agoapi: fix ipv6 firewall apis default role permissions (#6579)
Abhishek Kumar [Sun, 31 Jul 2022 11:19:29 +0000 (16:49 +0530)] 
api: fix ipv6 firewall apis default role permissions (#6579)

Fixes #6575

* fixes ipv6 firewall apis default role permissions
* test: use user apiclient for ipv6 firewall apis

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
8 weeks agoFixed list networks in projects after setting network permissions (#6546)
Harikrishna [Sun, 31 Jul 2022 11:15:36 +0000 (16:45 +0530)] 
Fixed list networks in projects after setting network permissions (#6546)

This PR fixes #6544 where it could not list networks in a project even after network permissions are set.

* Added test cases to existing component tests to test network permissions

* Moved test_network_permissions.py from component to smoke tests

* Added test_network_permissions to travis.yml under smoke tests