Disabled a few flaky tests and added corresponding tickets to fix.
authorPrateek Maheshwari <pmaheshw@linkedin.com>
Mon, 8 May 2017 20:29:23 +0000 (13:29 -0700)
committerJacob Maes <jmaes@linkedin.com>
Mon, 8 May 2017 20:29:23 +0000 (13:29 -0700)
Author: Prateek Maheshwari <pmaheshw@linkedin.com>

Reviewers: Jacob Maes <jmaes@linkedin.com>

Closes #171 from prateekm/disable-flaky-test

samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala
samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala
samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java

index 2f233c0..1afc26a 100644 (file)
@@ -52,11 +52,11 @@ import scala.collection.JavaConverters;
 import static org.junit.Assert.assertEquals;
 import static org.mockito.Matchers.anyLong;
 import static org.mockito.Matchers.anyObject;
+import static org.mockito.Mockito.atLeastOnce;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
-import static org.mockito.Mockito.atLeastOnce;
 
 // TODO(spvenkat) SAMZA-1183: Fix all commented out tests.
 public class TestAsyncRunLoop {
@@ -341,7 +341,8 @@ public class TestAsyncRunLoop {
     assertEquals(4, task1.windowCount);
   }
 
-  //@Test
+  // TODO fix in SAMZA-1183
+  // @Test
   public void testCommitSingleTask() throws Exception {
     CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
     CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
index d02a73c..58ecf99 100644 (file)
@@ -39,7 +39,8 @@ class TestProcessJob {
     job.waitForFinish(999999)
   }
 
-  @Test
+  // TODO: fix in SAMZA-1261
+  // @Test
   def testProcessJobKillShouldWork {
     val commandBuilder = new CommandBuilder {
       override def buildCommand = "sleep 999999999"
index b34003a..546f41b 100644 (file)
@@ -130,7 +130,9 @@ class TestExponentialSleepStrategy {
     exception
   }
 
-  @Test def testThreadInterruptInRetryLoop {
+  // TODO fix in SAMZA-1269
+  // @Test
+  def testThreadInterruptInRetryLoop {
     val strategy = new ExponentialSleepStrategy
     var iterations = 0
     var loopObject: RetryLoop = null
index 2d1681c..2ad6935 100644 (file)
@@ -97,7 +97,8 @@ public class TestLocalStoreMonitor {
     }
   }
 
-  @Test
+  // TODO fix in SAMZA-1243
+  // @Test
   public void shouldDeleteLocalTaskStoreWhenItHasNoOffsetFile() throws Exception {
     localStoreMonitor.monitor();
     assertTrue("Task store directory should not exist.", !taskStoreDir.exists());
@@ -147,7 +148,8 @@ public class TestLocalStoreMonitor {
     assertEquals(0, localStoreMonitorMetrics.diskSpaceFreedInBytes.getCount());
   }
 
-  @Test
+  // TODO fix in SAMZA-1243
+  // @Test
   public void shouldDeleteTaskStoreWhenTaskPreferredStoreIsNotLocalHost() throws Exception {
     Task task = new Task("notLocalHost", "test-task", "0",
                          new ArrayList<>(), ImmutableList.of("test-store"));