[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite
authorXingbo Jiang <xingbo.jiang@databricks.com>
Thu, 14 Jun 2018 06:20:48 +0000 (14:20 +0800)
committerhyukjinkwon <gurwls223@apache.org>
Thu, 14 Jun 2018 06:20:48 +0000 (14:20 +0800)
## What changes were proposed in this pull request?

We don't require specific ordering of the input data, the sort action is not necessary and misleading.

## How was this patch tested?

Existing test suite.

Author: Xingbo Jiang <xingbo.jiang@databricks.com>

Closes #21536 from jiangxb1987/sorterSuite.

core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java

index c145532..85ffdca 100644 (file)
@@ -129,7 +129,6 @@ public class UnsafeInMemorySorterSuite {
     final UnsafeSorterIterator iter = sorter.getSortedIterator();
     int iterLength = 0;
     long prevPrefix = -1;
-    Arrays.sort(dataToSort);
     while (iter.hasNext()) {
       iter.loadNext();
       final String str =